Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR performs cleanup work across the codebase, including removal of unused code, dependency updates, improved error handling, and enhanced test coverage for the protocol layer.
Key changes:
- Removed deprecated/unused API methods and message types
- Updated Python version requirement and dependency versions
- Added comprehensive error handling and logging to protocol communication
- Expanded test coverage with new protocol error scenarios
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_protocol.py | Added new test cases for error handling scenarios in protocol communication |
| pyproject.toml | Updated Python version requirement and bumped dependency versions |
| pyomnilogic_local/protocol.py | Enhanced error handling, added documentation, improved logging |
| pyomnilogic_local/omnitypes.py | Removed unused MessageType enum values |
| pyomnilogic_local/models/util.py | Removed unused type alias and inlined union types |
| pyomnilogic_local/models/telemetry.py | Fixed typo in comment |
| pyomnilogic_local/models/mspconfig.py | Removed unnecessary type ignore comment |
| pyomnilogic_local/models/filter_diagnostics.py | Removed unnecessary pylint disable comment |
| pyomnilogic_local/cli_legacy.py | Deleted entire legacy CLI file |
| pyomnilogic_local/cli/utils.py | Added @cache decorator to async functions |
| pyomnilogic_local/cli/debug/commands.py | Removed unused commands, added new parse_pcap command |
| pyomnilogic_local/cli/cli.py | Added startup data fetching with error handling |
| pyomnilogic_local/api.py | Removed deprecated alarm list and log config methods |
| .pre-commit-config.yaml | Updated pre-commit hook versions |
| .github/workflows/ci.yml | Added Python 3.12 and 3.14 to CI matrix |
| .github/copilot-instructions.md | Added new file with comprehensive Copilot integration guidelines |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- new debug command to parse PCAP data - remove functions that no longer appear to be supported by modern firmware - general cleanup and improved error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.